Skip to content

fix: PHP 8.4 - fgetcsv argument escape provided explicitly#163

Merged
bednar merged 5 commits intoinfluxdata:masterfrom
LuKo:PHP-8.4
Feb 13, 2025
Merged

fix: PHP 8.4 - fgetcsv argument escape provided explicitly#163
bednar merged 5 commits intoinfluxdata:masterfrom
LuKo:PHP-8.4

Conversation

@LuKo
Copy link
Contributor

@LuKo LuKo commented Feb 12, 2025

Closes #162

Proposed Changes

Added argument escape.

Checklist

  • CHANGELOG.md updated
  • Commit messages are conventional
  • Sign CLA (if not already signed)

Lukáš Kohout added 4 commits February 12, 2025 23:23
Function fgetcsv(), argument escape provided explicitly
9af7b44 
As of PHP 8.4.0, depending on the default value of escape is deprecated. It needs to be provided explicitly either positionally or by the use of named arguments.
Update CHANGELOG.md
27892e0
Backward compatibility with PHP 7.*
f6647e9
Fix empty character bug
573a44f
@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2025 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.09%. Comparing base (e9f4c54) to head (379b755).
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master     #163   +/-   ##
=========================================
  Coverage     75.09%   75.09%           
  Complexity      433      433           
=========================================
  Files            25       25           
  Lines          1104     1104           
=========================================
  Hits            829      829           
  Misses          275      275
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bednar
bednar requested changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LuKo thanks for your PR 👍

Can you please cover your changes in https://github.com/influxdata/influxdb-client-php/blob/master/tests/FluxCsvParserTest.php?

Thx

@LuKo
Copy link
Contributor Author

LuKo commented Feb 13, 2025

I’m not sure how to do it when it’s just an update to the function call syntax without changing the logic. Could I kindly ask you to make it now, and I will learn it for the next time? Thank you very much.

@bednar
Copy link
Contributor

bednar commented Feb 13, 2025

Ohh, sorry for the misunderstanding. Now it’s clear to me. LGTM 🚀

bednar
bednar approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh, sorry for the misunderstanding. Now it’s clear to me. LGTM 🚀

@bednar bednar changed the title PHP 8.4 - fgetcsv argument escape provided explicitly fix: PHP 8.4 - fgetcsv argument escape provided explicitly Feb 13, 2025
@bednar bednar merged commit 1b59d57 into influxdata:master Feb 13, 2025
11 of 12 checks passed
@bednar bednar added this to the 3.7.0 milestone Feb 13, 2025
@LuKo LuKo deleted the PHP-8.4 branch February 25, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bednar bednar bednar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.7.0

Development

Successfully merging this pull request may close these issues.

PHP 8.4 - fgetcsv() needs provide explicitly argument escape

3 participants

@LuKo @codecov-commenter @bednar